First clear solution for House Password by tigelane - python coding challenges

Enable Javascript in your browser and then refresh this page, for a much enhanced experience.

First solution in Clear category for House Password by tigelane

import re

def checkio(data):

    if re.search("[a-z]+", data):
        if re.search("[A-Z]+", data):
            if re.search("[0-9]+", data):
                if len (data) >= 10:
                    return True
    
    return False
        
#Some hints
#Just check all conditions


if __name__ == '__main__':
    #These "asserts" using only for self-checking and not necessary for auto-testing
    assert checkio('A1213pokl') == False, "1st example"
    assert checkio('bAse730onE4') == True, "2nd example"
    assert checkio('asasasasasasasaas') == False, "3rd example"
    assert checkio('QWERTYqwerty') == False, "4th example"
    assert checkio('123456123456') == False, "5th example"
    assert checkio('QwErTy911poqqqq') == True, "6th example"

Nov. 19, 2014

Comments:

stenskjaer on April 8, 2015, 10:16 a.m.
I like the simplicity of the fall-through on each condition. But to me the <pre class='brush: python'>return False </pre> at the outer level gives me the false expectation that it will return false. I guess it's a matter of where you place the negation, because the alternative solution would be to check for the absence of the required chars and otherwise return True, like so: <pre class='brush: python'>def checkio(data): if (re.search("[A-Z]+", data) == None): return False elif (re.search("[a-z]+", data) == None): return False elif (re.search("[0-9]+", data) == None): return False elif (len(data) < 10): return False # All conditions have been met. else: return True </pre> Any thoughts on what is more readable or idiomatic?

tigelane on April 11, 2015, 12:04 a.m.
I think it would have been more clear if I put "else: return false". I hate the idea of writing return False 4 times (in this case). If I need to add more requirements I only need to add the requirement, not two more lines as is your example. In my normal code I would have set a variable (let's say "retval") to false at the top, then set it to True if all conditions were met, and finally only used a single "return" statement. Not sure if that's more clear, but at least you would have gone looking for what I did. In this example it's not hard to find it, but in a much larger code block you would know to go looking for "retval" to find what I'm doing. Thanks for the comments! <pre class='brush: python'>import re def checkio(data): retval = False if re.search("[a-z]+", data): if re.search("[A-Z]+", data): if re.search("[0-9]+", data): if len (data) >= 10: retval = True return retval </pre>

Strings Theory

0 %

PyCharm The Python IDE for Professional Developers. Enjoy productive Python, web and scientific development with PyCharm. Download it now!