• Incinerator: "dialogues" task

 

Hi,

I would like to give some feedback on incinerator dialogues task:

I managed to pass the 3rd 1/1 test even though the code was faulty, the test itself would've caught the error if it accounted for each interlocutor sending more than one message, I corrected my code in showrobotdialogue, but your test is still checking only one round of messages, maybe you would like to add another round of messages to the test like you did in showhumandialogue test

Incomplete test:

chat = Chat() 
me = Human('Xander') 
my_digital_clone = Robot('Model AX-88') 
chat.connect_human(me) 
chat.connect_robot(my_digital_clone) 
me.send("What a nice day! Do you have some plans?") 
my_digital_clone.send("Code. Code. Code. Nothing else matters.") 
chat.show_robot_dialogue()

Complete test example:

chat = Chat() 
bob = Human('Bob') 
ann = Robot('Ann-1244c') 
chat.connect_human(bob) 
chat.connect_robot(ann) 
bob.send("Hi, Ann! Is your part of work done?") 
ann.send("Hi, Bob. Sorry, I need a few more hours. Could you wait, please?") 
bob.send("Ok. But hurry up, please. It's important.") 
ann.send("Sure, thanks.") 
chat.show_human_dialogue()

From: https://py.checkio.org/mission/dialogues/solve/

HTTP_USER_AGENT:

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0