A simple solution clear solution for The Ship Teams by vnkvstnk - python coding challenges

Enable Javascript in your browser and then refresh this page, for a much enhanced experience.

A simple solution solution in Clear category for The Ship Teams by vnkvstnk

def two_teams(sailors):
    team_young = [name for name,age in sailors.items() if (age>=20) and (age<=40)]
    team_old = [name for name in sailors.keys() if name not in team_young]
    return [sorted(team_old), sorted(team_young)]

June 2, 2019

Comments:

Pouf on July 7, 2020, 5:40 p.m.
A few tips :) - you can omit parentheses around `(age>=20)` and `(age<=40)`. You can even write `if 20 <= age <= 40` - `teamyoung` and `teamold ` could be generator expressions (`(name for name,age in [...]`) or set comprehensions (`{name for name,age in [...]`) instead of list comprehensions to use less memory and cpu. `sorted()` on line 4 would still work. - if `teamyoung` was a set, you could write `teamold = set(sailors) - team_young`

Pouf on July 7, 2020, 6:27 p.m.
A few tips :) <ul> <li>you can omit parentheses around `(age>=20)` and `(age<=40)`. You can even write `if 20 <= age <= 40`</li> <li>`teamyoung` and `teamold ` could be generator expressions (`(name for name,age in [...]`) or set comprehensions (`{name for name,age in [...]`) instead of list comprehensions to use less memory and cpu. `sorted()` on line 4 would still work.</li> <li>if `teamyoung` was a set, you could write `teamold = set(sailors) - team_young`</li> </ul>

vnkvstnk on July 8, 2020, 3:48 p.m.
Thank you for the tips! Using this "short" condition should definitely be preferred, totally agree. Regarding generators, I opted for lists since the input size is 100 at most, I thought using generators wouldn't give significant advantage, but it was a long time ago, now I would go for generators regardless :) And yeah, sets definitely should be considered here.

Escher

0 %

PyCharm The Python IDE for Professional Developers. Enjoy productive Python, web and scientific development with PyCharm. Download it now!