First clear solution for Roman Numerals by GodMode-On - python coding challenges

Enable Javascript in your browser and then refresh this page, for a much enhanced experience.

First solution in Clear category for Roman Numerals by GodMode-On

def checkio(data):
    arab = [1, 4, 5, 9, 10, 40, 50, 90, 100, 400, 500, 900, 1000]
    roman = ['I','IV','V','IX','X','XL','L','XC','C','CD','D','CM','M']
    
    res = ""
    i = len(arab)-1
    
    while data > 0:
        if data >= arab[i]:
            res += roman[i]
            data -= arab[i]
        else:
            i -= 1
            
    return res

Jan. 19, 2015

Comments:

Butch on July 2, 2015, 4:15 a.m.
It's short and elegant. Easy to read also.

nanpa on Nov. 14, 2015, 5:13 a.m.
Elegant

Franky on Dec. 13, 2015, 9:14 a.m.
two matched arrays means using dictionary or list of tuples are better way.

Alex581995 on June 12, 2024, 8:37 a.m.
Strengths: Clear and concise: The code is easy to understand and follows a simple logic. Efficient: The while loop iterates only as many times as necessary to convert the number. Correct: The code accurately converts Arabic numerals to Roman numerals. Areas for Improvement: Data structures: Using lists for arab and roman is fine, but a dictionary would be more efficient for mapping between the two. Error handling: The code doesn't handle invalid input (e.g., negative numbers, non-integer values). Adding error handling would make the code more robust. Documentation: Adding comments to explain the logic of the code would improve readability and maintainability.

GitHub

0 %

PyCharm The Python IDE for Professional Developers. Enjoy productive Python, web and scientific development with PyCharm. Download it now!