First clear solution for Pawn Brotherhood by Kerulen - python coding challenges

Enable Javascript in your browser and then refresh this page, for a much enhanced experience.

First solution in Clear category for Pawn Brotherhood by Kerulen

def safe_pawns(pawns):
    answer = 0
    for pawn in pawns :
        if chr(ord(pawn[0])-1)+str(int(pawn[1])-1) in pawns or chr(ord(pawn[0])+1)+str(int(pawn[1])-1) in pawns : answer +=1
    return answer

if __name__ == '__main__':
    #These "asserts" using only for self-checking and not necessary for auto-testing
    assert safe_pawns({"b4", "d4", "f4", "c3", "e3", "g5", "d2"}) == 6
    assert safe_pawns({"b4", "c4", "d4", "e4", "f4", "g4", "e5"}) == 1

July 30, 2014

Comments:

baozhao123 on Aug. 1, 2014, 2:55 a.m.
simple and clear

hanpari on Aug. 1, 2014, 6:37 p.m.
But a little bit unreadable, don't you think? :) (At least for Clear category.)

Hayertjez on Nov. 9, 2015, 11:37 a.m.
I agree, a bit unreadable.

cmantas on Dec. 21, 2015, 6:24 p.m.
++1

jbannister on Aug. 3, 2014, 11:20 p.m.
I don't find this clear at all. Maybe it should be in another category.

Cjkjvfnby on Aug. 5, 2014, 10:04 p.m.
It is simple and clear, but bad formated. Long string make it hard to read.

Kerulen on Aug. 6, 2014, 6:49 a.m.
Thank you for the advice

logi on Sept. 27, 2019, 8:13 p.m.
PEP8: <a href="https://www.python.org/dev/peps/pep-0008/">https://www.python.org/dev/peps/pep-0008/</a>#maximum-line-length

Booplesnoot on June 12, 2020, 4:36 p.m.
Maybe instead of <pre class='brush: python'>if chr(ord(pawn[0])-1)+str(int(pawn[1])-1) in pawns or chr(ord(pawn[0])+1)+str(int(pawn[1])-1) in pawns : answer +=1 </pre> this would be better? <pre class='brush: python'>if chr(ord(pawn[0])-1)+str(int(pawn[1])-1) in pawns: answer += 1 elif chr(ord(pawn[0])+1)+str(int(pawn[1])-1) in pawns: answer += 1 </pre>

ArchTauruS on Aug. 8, 2014, 8:46 a.m.
clear and nice

kendriu on Aug. 30, 2014, 10:29 p.m.
Not readable. If statement shouldn't be oneliner.

artemrudenko on Sept. 3, 2014, 12:22 p.m.
Short and clear. Thumbs up

acman on Sept. 4, 2014, 1:43 p.m.
Thumbs up

maurice.makaay on Oct. 28, 2014, 5:01 p.m.
This does not deserve the category Clear IMO. This kind of logic: <pre class='brush: python'>chr(ord(pawn[0])-1)+str(int(pawn[1])-1) </pre> really would improve from being moved into a separate function, where the logic is handled in a few lines, so the reader can actually follow what is going on here, as well as getting rid of the cut-and-pasty code duplication. But apart from the readability, I do not particularly like this solution, because for example a pawn at "a1" will result in a check for another pawn at position "`0", which is an invalid board position. Making implicit use of the invalidity of the field position does feel like an ugly trick to me (of the kind that would hunt you in a production system) moving the solution into the Scary category.

Peter.White on April 2, 2015, 8:23 p.m.
<pre class='brush: python'>chr(ord(pawn[0])-1)+str(int(pawn[1])-1) </pre> What is so hard to understand there? Those are buil-in functions, which one is supposed to know, I think. And about the invalid board position, that one is checked against a set of valid positions (precondition), so no harm there. I did the same, with that exact reasoning. Even if one were to say, that the precondition must be checked, that should be done by the time that part of code is reached.

juestr on April 12, 2019, 9:19 p.m.
It's hard to read even if you know the functions. Having this blurb 2 times with a single character changed doesn't make it easier, and screams for refactoring.

qler89 on Dec. 1, 2014, 10:20 p.m.
code line exceeded 80 symbols. please use double-lines

direwolf on Dec. 13, 2014, 2:32 a.m.
very clear!

saxtouri on Jan. 14, 2015, 5:51 p.m.
We need a "creative but still pep8" section...

ForcePush on Feb. 20, 2015, 10:54 a.m.
Beautiful.

mlb00 on March 24, 2015, 2:14 p.m.
This is a nice solution but PEP 8 should be encouraged, especially since this site is to promote coding education! <blockquote> Limit all lines to a maximum of 79 characters. For flowing long blocks of text with fewer structural restrictions (docstrings or comments), the line length should be limited to 72 characters. </blockquote> <a href="https://www.python.org/dev/peps/pep-0008/">https://www.python.org/dev/peps/pep-0008/</a>#maximum-line-length <pre class='brush: python'>def safe_pawns(pawns): answer = 0 for pawn in pawns : if chr(ord(pawn[0])-1)+str(int(pawn[1])-1) in pawns or \ chr(ord(pawn[0])+1)+str(int(pawn[1])-1) in pawns : answer +=1 return answer </pre>

spencerpomme on March 25, 2015, 2:14 a.m.
simple and short but it drives me crazy that squize them in one line...

Peter.White on April 2, 2015, 8:15 p.m.
If I have to scroll horizontally to read it, it is not clear. -1 for bad style. The approach I like. I used the same.

dmitrii606 on April 5, 2015, 3:58 p.m.
Very long and not the fastest way

AndreyKorolev on April 6, 2015, 9:06 p.m.
Same solution as mine )

tommycarstensen on April 24, 2015, 1:47 p.m.
Why is this solution voted the most clear solution??? It's short, but not clear.

rajsharmabannu on May 26, 2015, 1:16 p.m.
nice one! :) only if it were more readable!

mreinhardt on June 5, 2015, 5:34 a.m.
Tenet of Python is to be readable, otherwise might as well use Perl.

Pumba_UA on June 27, 2015, 7:52 a.m.
My solution is the same, but more readable...

JianLiu on July 16, 2015, 12:29 p.m.
can't read it

tartavull on July 19, 2015, 8:04 p.m.
it hard to read for me

bryanandrade on July 27, 2015, 11:34 p.m.
I didn't find this very clear, but it was definitely a workable solution.

dsethlewis on July 30, 2015, 10:46 p.m.
Only comment is that you should break the boolean statement up into multiple lines.

Sedov on Aug. 4, 2015, 2:59 p.m.
Used pretty much the same approach, but separated it in several lines. Your code is cool and concise :)

Sedfer on Oct. 29, 2015, 6:54 p.m.
This solution shouldn`t be on the 1st place in CLEAR category

bbbass123 on Jan. 30, 2016, 6:56 p.m.
In my opinion one line ifs should be reserved for really boring logic. This is interesting logic, therefore use standard indentation.;-)

AlexPro on Feb. 2, 2016, 6:39 p.m.
Cool,but I don't like scrolling

p4r4d0x42 on Feb. 23, 2016, 11:18 p.m.
I borrowed your solution and came up with this: <a href="http://www.checkio.org/mission/pawn-brotherhood/publications/p4r4d0x42/python-27/second/">http://www.checkio.org/mission/pawn-brotherhood/publications/p4r4d0x42/python-27/second/</a> Not clear but it is creative at least. One liners are fun.

ljy95135 on April 18, 2016, 5:57 a.m.
One line is hard to read. But it helps for me to find that I use lot of useless if-test.

ilusha90 on April 27, 2016, 10:05 a.m.
Nice!

szperajacyzolw on July 10, 2016, 10:14 a.m.
I gave you a thumb up for clever solution, but it is definitely not clear solution.

KODeKarnage on Sept. 13, 2016, 6:44 a.m.
Sorry, not clear, too many inline brackets.

zancas on Oct. 20, 2016, 3:31 p.m.
This is not "clear" or "readable"... I think it belongs in "Creative".

AlexGiesbrecht on Jan. 12, 2017, 6:33 p.m.
neither clear nor readable, lines too long etc...

LOACH on Feb. 11, 2017, 1:21 p.m.
Nice work!

R2R on March 27, 2017, 8:46 p.m.
Good solution! But there's better one: <a href="https://py.checkio.org/mission/pawn-brotherhood/publications/R2R/python-3/tiny/">https://py.checkio.org/mission/pawn-brotherhood/publications/R2R/python-3/tiny/</a> Check it out!

TheTownBoolean on March 29, 2017, 11:24 p.m.
Why is it that the solutions that or voted high are always almost one liners :) lol

abehad701 on June 6, 2017, 12:18 a.m.
similar to mine in using chr/ord, though i did it in the form of a list comprehension

pumacens_ceb54daf41d74653bc014 on Oct. 14, 2017, 7:34 p.m.
1 line of code vs a 30 lines code :,v

pavoli on Oct. 20, 2017, 3:06 a.m.
the same like mine answer))

ajmal.nazir on Nov. 13, 2017, 11:14 p.m.
wow... I was pleased with my self for managing about 7 lines.... I used the same logic but didn't realise that I can make some of my code redundant... Nice... and Thanks

Tairraos on May 20, 2018, 7:08 a.m.
```python return [chr(ord(c[0]) - 1) + str(int(c[1]) - 1) in pawns or chr(ord(c[0]) + 1) + str(int(c[1]) - 1) in pawns for c in pawns].count(True) ```

hbxz on May 20, 2018, 12:07 p.m.
It is short, but not so much clear.

Alex_ZhangCN on June 13, 2018, 1:15 a.m.
Same idea

belary on July 26, 2018, 2:52 a.m.
nice

YoPlaya1 on Aug. 19, 2018, 10:40 a.m.
I wrote the exact same word for word!

songbai121 on Sept. 6, 2018, 1:54 a.m.
Fancy one line code to show off, but not as readable.

trzyho on Sept. 13, 2018, 1:11 p.m.
great

Igor_Styopin on May 31, 2019, 2:32 p.m.
nice

CrossFireZero on Aug. 8, 2019, 9:16 a.m.
very nice and clever!

krzysztofrrr on Aug. 26, 2019, 7:17 a.m.
cool. I like it.

Ermak on Oct. 10, 2019, 10:52 a.m.
unreadable

Look up in the Dict()

0 %

PyCharm The Python IDE for Professional Developers. Enjoy productive Python, web and scientific development with PyCharm. Download it now!