First clear solution for Max Digit by mr_vads - python coding challenges

Enable Javascript in your browser and then refresh this page, for a much enhanced experience.

First solution in Clear category for Max Digit by mr_vads

def max_digit(number: int) -> int:
    #n=[]
    #for a in str(number):
    #    n.append(a)
    return int(max(str(number)))


if __name__ == '__main__':
    print("Example:")
    print(max_digit(0))

    # These "asserts" are used for self-checking and not for an auto-testing
    assert max_digit(0) == 0
    assert max_digit(52) == 5
    assert max_digit(634) == 6
    assert max_digit(1) == 1
    assert max_digit(10000) == 1
    print("Coding complete? Click 'Check' to earn cool rewards!")

July 18, 2021

Comments:

remdch on Aug. 30, 2021, 9:42 p.m.
Too much operations in one string, useful comments But correct anyway

mr_vads on Sept. 1, 2021, 10:01 a.m.
so you think it's too complicated to read? or what do you mean

remdch on Sept. 1, 2021, 8:38 p.m.
Well, in this case no, but you have to always have in mind that someone will read your code. I had to review your code as a Random Reviewer, so I had to be strict )

mr_vads on Sept. 1, 2021, 8:44 p.m.
I'm not sure if I understand your point. This particular task is pretty simple, and the function does its job. What would you suggest as a solution to be more specific?

remdch on Sept. 2, 2021, 5:28 p.m.
<pre class='brush: python'>def max_digit(number: int) -> int: string = str(number) result = int(max(string)) return result </pre> 1. clean of rubbish comments 2. not more than two operations per line (but as the code is short and clear here it's not required)

mr_vads on Sept. 2, 2021, 6:31 p.m.
oh, so you were talking about comments, right? I left them occasionally but it can be seen as another solution, anyway. thanks for clearing things up!

remdch on Sept. 2, 2021, 6:33 p.m.
Good luck!

Strings and Integers

0 %

PyCharm The Python IDE for Professional Developers. Enjoy productive Python, web and scientific development with PyCharm. Download it now!