First clear solution for House Password by indentationerror - python coding challenges

Enable Javascript in your browser and then refresh this page, for a much enhanced experience.

First solution in Clear category for House Password by indentationerror

def checkio(data):
    if data.lower()!=data and data.upper()!=data and len(data)>=10 and any(char.isdigit() for char in data):
        return True
    else:
        return False

Dec. 15, 2015

Comments:

Glacier960 on Dec. 18, 2015, 3:27 a.m.
any() is a useful function!!

sakfa on Dec. 20, 2015, 9:13 a.m.
Code is clear, but: 1. it creates 2 unnecessary copy of data (to compute result of data.lower and data.upper) 2. loops over data at least 5 times (while the task could be solved with just 1 loop) so it is a little bit wasteful as a minimum I would rearrange checks of conditions - first check for len (as it's the cheapest to execute), then check for digit and finally check for lower and upper characters (which btw could be solved with calls to isupper() and islower() methods of char just as you did with isdigit()) Cheers

indentationerror on Dec. 21, 2015, 4:15 a.m.
thnx for the review @sakfa

Strings Theory

0 %

PyCharm The Python IDE for Professional Developers. Enjoy productive Python, web and scientific development with PyCharm. Download it now!