First clear solution for House Password by Jemmity - python coding challenges

Enable Javascript in your browser and then refresh this page, for a much enhanced experience.

First solution in Clear category for House Password by Jemmity

def checkio(data):
    return any(i.isdigit() for i in data) \
        and any(i.isupper() for i in data) \
        and any(i.islower() for i in data) \
        and len(data) > 9

April 26, 2015

Comments:

lancelote on May 11, 2015, 4:24 p.m.
Nice `any` use! But you should probably check length first so it will shut down evaluation before loops if password is not long enough.

veky on May 12, 2015, 10:34 a.m.
That doesn't make as much sense as you probably think. If the password is short, then the checks will take a very small time, so the effect of other checks is bounded. BTW any can be used pointfree too: <pre class='brush: python'>any(map(str.isdigit, data)) </pre> And also all can be used for the outer `and`. But it's probably overkill. :-)

lancelote on May 12, 2015, 11:17 a.m.
<blockquote> the checks will take a very small time, </blockquote> Yeah, you right. Just intuitive thing to do. <blockquote> But it’s probably overkill. :-) </blockquote> Is it? I really love this idea = )

veky on May 12, 2015, 11:22 a.m.
Ok then: <a href="http://www.checkio.org/mission/house-password/publications/veky/python-3/cnf/?ordering=most_voted">http://www.checkio.org/mission/house-password/publications/veky/python-3/cnf/?ordering=most_voted</a>

lancelote on May 12, 2015, 3:03 p.m.
I think readability can be significantly improved with simple indentation and meaningful variable names: <pre class='brush: python'>def checkio(data): return len(data) > 9 and \ all(any(map(rule, data)) for rule in (str.isdigit, str.isupper, str.islower)) </pre> And I thought about something like this: <pre class='brush: python'>def checkio(data): return all((len(data) > 9, any(map(str.isdigit, data)), any(map(str.isupper, data)), any(map(str.islower, data)))) </pre>

veky on May 13, 2015, 5:08 a.m.
First snippet: variable names, of course. But Python frowns on that usage of indentation. This is not LISP. :-) And `\` continuation can usually be avoided. <pre class='brush: python'>checkio = lambda data: len(data) >= 10 and all( any(map(criterion, data)) for criterion in (str.isdigit, str.isupper, str.islower)) </pre> Second snippet is missing the point. `all((a, b, c, d))` is much clearer written as `a and b and c and d`. You don't write `sum((a, b, c, d))` instead of `a + b + c + d`, right? :-) It's the factoring out of common code (`any(map(..., data))`) which makes `all` suitable since it accepts a generator.

lancelote on May 13, 2015, 6:59 a.m.
Ok, thanks, I got it.

Strings Theory

0 %

PyCharm The Python IDE for Professional Developers. Enjoy productive Python, web and scientific development with PyCharm. Download it now!