First clear solution for Digit Stack by bukebuer - python coding challenges

Enable Javascript in your browser and then refresh this page, for a much enhanced experience.

First solution in Clear category for Digit Stack by bukebuer

def digit_stack(commands):
    stack, sum = [], 0
    for cmd in commands:
        if 'PUSH' in cmd:
            stack.append(int(cmd.split(' ')[1]))
        elif cmd=='POP':
            sum += stack.pop() if stack else 0
        else:
            sum += stack[-1] if stack else 0
    return sum

July 2, 2014

Comments:

zver1zver2 on July 9, 2014, 2:48 p.m.
cool good code

aotus on Aug. 10, 2014, 12:34 a.m.
Your use of the ternary operator is a bit tidier than catching an IndexError, which is what I did. I like your way better.

bukebuer on Aug. 10, 2014, 11:12 a.m.
Thx. Actually I believe your method is more recommended because of EAFP rule. :)

artemrudenko on Aug. 25, 2014, 12:51 p.m.
Not a good idea to redefine 'sum' as a variable since it is a python core function. Also there is not need to do split: int(cmd.split(' ')[1]) - you can use int(cmd[-1]) instead.

bukebuer on Aug. 25, 2014, 3:29 p.m.
You're right on 'sum'. int(cmd.split(' ')[1]) is to in case there may exist number larger than 9.

artemrudenko on Aug. 25, 2014, 4 p.m.
Maybe, but from task description: "- "PUSH X" -- add X in the stack, where X is a digit." so that is why i have decided that cmd[-1] is enaught.

P1O1E on Jan. 30, 2015, 2:48 a.m.
I thought using a separate function for each command type would be neat - you just proved me wrong!

texom512 on Aug. 20, 2015, 12:48 p.m.
One variable per line (PEP8)!

V.Shkaberda on March 6, 2020, 9:55 p.m.
Where is that in PEP8? I believe you mixed up variables and statements. ("multiple statements on the same line".)

vby on Jan. 16, 2021, 8:48 p.m.
Is it right and correct to write just "if stack: sum += stack.pop()"? It looks clearer and simpler, it seems.

Ice Base

0 %

You ClassRoom Demo is Ready With the new tool CheckiO ClassRoom, you will be able to analyze your students' progress, have your own leaderboard, change missions order on the map, and so on.