2-liner: cleanest clear solution for Bigger Price by przemyslaw.daniel - python coding challenges

Enable Javascript in your browser and then refresh this page, for a much enhanced experience.

2-liner: cleanest solution in Clear category for Bigger Price by przemyslaw.daniel

def bigger_price(limit, data):
    return sorted(data, key=lambda x: x['price'], reverse=True)[:limit]

Oct. 20, 2017

Comments:

veky on April 25, 2018, 1:33 p.m.
Compared to <a href="https://py.checkio.org/mission/bigger-price/publications/veky/python-3/connecting-the-dots/?ordering=most_voted&filtering=group">what</a>? :-D

alexander.gorelyshev on April 27, 2018, 11:19 a.m.
Most terse -- sure. Not necessarily cleanest or clearest, though.

veky on Aug. 27, 2020, 3:51 a.m.
It's not even tersest. :-)

DeCooper on June 14, 2018, 9:37 p.m.
Same as mine, so 4 stars! ;-)

hugoboss on Aug. 5, 2018, 6:36 p.m.
sorry, but x['price'] isn't a safe solution. Could be an exception when the data missed.

veky on Aug. 22, 2018, 11:31 a.m.
You have a very weird definition of 'safe'. And your code does the exact same thing, so I don't really see what you're trying to say.

moosetraveller on Aug. 26, 2020, 11:48 p.m.
I came up with the same solution but we all run into trouble if <pre class='brush: python'>data = [ {"name": "bread", "price": 100}, {"name": "wine", "price": 138}, {"name": "meat", "price": 15}, {"name": "water", "price": 1}, {"name": "soap"} # someone forgot the price ] </pre> Can we be sure that we always have clean data, for example, when using data from a JSON file with json.load(file_name)? ;-)

veky on Aug. 27, 2020, 3:58 a.m.
We can never be sure of anything. (For every solution, I can construct an input that will produce any behavior you like---or even any that you don't like.;) But that's not our job. How exactly do you define "trouble"? The point is to write a function that will take any input satisfying the precondition, into any output satisfying the postcondition. (At least here the precondition explicitly says each dict has those two keys.) What it does with the input not satisfying the precondition, we don't care---and we must not care, since we cannot constrain that behavior in any meaningful way. Try it. ;-)

alekseykonotop on Sept. 19, 2018, 10:31 a.m.
I wrote exactly the same function)))

AndreyAparinov on Nov. 14, 2018, 3:40 p.m.
The solution might be not very efficient in case the list is long. You sort the whole list and then take only few elements. For example, if you need to find one biggest element and it is on first position and the whole list contains 1 million elements this algorithm will do to much waste calculations.

przemyslaw.daniel on Jan. 2, 2019, 8:01 p.m.
Yes, that's correct but what we have here is clear category. How about solution for such <a href="https://py.checkio.org/mission/bigger-price/publications/przemyslaw.daniel/python-3/21-liner-first-proposal/">cases</a> in speedy taste

bishopuam on Nov. 23, 2019, 1:10 a.m.
Good

vlad.bezden on March 22, 2020, 1:23 p.m.
Nice solution. Happy coding ;)

yukipr on April 9, 2020, 9:02 a.m.
It's a very good and clean solution. However it can be a little more simpler(maybe not) :) def bigger_price(limit, data): return sorted(data, key=lambda x: x['price'])[:limit-1:-1]

przemyslaw.daniel on April 9, 2020, 2:02 p.m.
Not too much. You reversed the result at the end which is additional step that slows down the code. Simpler way below <pre class='brush: python'> def bigger_price(limit, data): return sorted(data, key=lambda x: -x['price'])[:limit] </pre>

veky on April 4, 2021, 4:49 a.m.
<blockquote> which is additional step that slows down the code </blockquote> ignoring the `nlogn` elephant in the room that actually slows down the code: sorting. :-P

Pouf on June 28, 2020, 9:19 a.m.
`simpler != shorter` ! `reverse=True` is straightforward, whereas using complex slicing makes it less readable. It would take more time to understand what happens.

krzysztofrrr on May 4, 2020, 9:46 p.m.
exactly as mine :)

saketkarajagi on June 16, 2020, 4:19 a.m.
Nice

Binara on Sept. 15, 2020, 2:15 p.m.
Good

jsg-inet on June 14, 2021, 7:17 a.m.
Using Python potential to the limit. Very nice solution. (Oh dear, what a lot of things I have to learn and understand yet!)

CDG.Axel on Aug. 29, 2021, 11:49 a.m.
Using sort method of the list will be a little faster. But it will be two lines :)

chrisw63 on Sept. 2, 2021, 4:56 p.m.
Rats! I went for sort() instead, and never though of returning a slice! Putting them both together is obvious now that I see it. Thanks for this.

TrexxaByte on Jan. 4, 2022, 5:35 p.m.
Wow... this has certainly given me strong motivation to learn and become familiar with lambda (along with any/all aspects it may include). Ugh... its going to be ... fun. LOL

GrumpyEconomist on Feb. 28, 2022, 7:07 a.m.
Always like the use of lambda functions :) good solution, easy to follow and nice and short Keep up the good work!

evanmccaleb on May 3, 2022, 4:59 a.m.
I'll just add that I think this is one step from being the CLEAREST solution. Having all the work on one line (don't count the def line) vs two obfuscates things a bit. Clearest to me would be sorting the list. then returning 0-limit items from the list on a second line.

Look up in the Dict()

0 %

PyCharm The Python IDE for Professional Developers. Enjoy productive Python, web and scientific development with PyCharm. Download it now!